Google Git
Sign in
chromium / chromium / src / 548258ccd28b657f7573ca832fbfd557c2922601
commit548258ccd28b657f7573ca832fbfd557c2922601[log] [tgz]
authorJoshua Bell <jsbell@chromium.org>Mon Feb 12 21:10:42 2018
committerCommit Bot <commit-bot@chromium.org>Mon Feb 12 21:10:42 2018
treefb6363650236c2104543a28d04aad1f9bef6dba7
parentaca48796095187056bc808503b3562fd3baf2af0 [diff]
Async Cookies: Fix globals in idlharness test

Globals (Window, ServiceWorkerGlobalScope, etc) get special bindings
treatment for methods/properties and IDL tests for features need to
declare these types correctly for correct results. Fix the SW test for
the new cookie store API by marking the global with the [Global]
extended attribute; this reveals that our implementation passes all
the bindings test cases.

Bug: 729800
Change-Id: I87747ed2af8d932342e24c9400524d88c9df73a7
Reviewed-on: https://chromium-review.googlesource.com/914568
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536189}
3 files changed
tree: fb6363650236c2104543a28d04aad1f9bef6dba7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .