commit | 5487d51f9175a69613e7b715be437ece3c1d88e5 | [log] [tgz] |
---|---|---|
author | Xiaoqian Dai <xdai@chromium.org> | Sat Sep 16 03:54:06 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Sep 16 03:54:06 2017 |
tree | 6569c8aff697ac1241dfbcf739a1fec598e7de90 | |
parent | b94970f59995254c0457edfff64ab7162b950738 [diff] |
Revert "Clang: enable -instcombine-lower-dbg-declare=1" This reverts commit 32750c1251012624a87fb97098bd0f6a60ffa8ed. Reason for revert: This CL breaks most of the informational builds https://uberchromegw.corp.google.com/i/chromeos.chrome/waterfall?reload=300. See an example here: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-tot-chrome-pfq-informational/builds/6039 Original change's description: > Clang: enable -instcombine-lower-dbg-declare=1 > > This enables better optimized debug info for address-taken values > at the cost of potentially inaccurate debug info in some situations. > > We believe turning this on is the right trade-off for developers > debugging Chromium on all platforms, but especially on Windows where > values that are available in MSVC's debug info would otherwise show > as unavailable when using Clang. > > The goal (crbug.com/765793) is to make Clang's optimized > debug info good enough in all cases that this compromise is not > necessary. > > Note: This requires Clang r313108 or later. > > Bug: 761633, 753736, 765793 > Change-Id: Ia0ed38c499fac282a3c8ab27c5fd5571fdfab84d > Reviewed-on: https://chromium-review.googlesource.com/669314 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502428} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: I4fea2ab8ec9571d4afb66cd3912c5975e0b9395c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 761633, 753736, 765793 Reviewed-on: https://chromium-review.googlesource.com/669825 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#502484}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .