Google Git
Sign in
chromium / chromium / src / d501f82a0b54ad36786b8e2ca22ccf881a37ce05
commitd501f82a0b54ad36786b8e2ca22ccf881a37ce05[log] [tgz]
authorAndrey Lushnikov <lushnikov@chromium.org>Tue Apr 17 06:11:21 2018
committerCommit Bot <commit-bot@chromium.org>Tue Apr 17 06:11:21 2018
treeaf531df501f1560367ecdacb36cc7e74064774a9
parentfb02f0ec4a52fa0a19009a54d7c9e65b25ca92f5 [diff]
DevTools: page.navigate should fail when server returned HTTP 204

Browser doesn't commit navigation if server responds HTTP 204 / HTTP 205
for the main resource or if navigation triggers a download.

In these cases, navigation is considered aborted.

This patch teaches page.navigate to return "ERR:ABORTED" when
either of the usecases happens.

R=dgozman, pfeldman

Change-Id: I0017e458c2f905429c7234bc8f9be20a4201bbfd
Reviewed-on: https://chromium-review.googlesource.com/1009487
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551261}
5 files changed
tree: af531df501f1560367ecdacb36cc7e74064774a9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. webrunner/
  55. .clang-format
  56. .eslintrc.js
  57. .git-blame-ignore-revs
  58. .gitattributes
  59. .gitignore
  60. .gn
  61. .vpython
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .