commit | 5589652282f5255cdfb36e86ea098c781557c580 | [log] [tgz] |
---|---|---|
author | Xinan Lin <linxinan@chromium.org> | Thu Nov 19 01:21:20 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 19 01:21:20 2020 |
tree | dd3a07e115a7abd57bea8c1f26413894b4fafde8 | |
parent | 4447336100328230102b0c90625f44c00c9c5a8c [diff] |
Revert "Improve the setup logic for tryserver" This reverts commit 4447336100328230102b0c90625f44c00c9c5a8c. Reason for revert: Breaks infra repo. See crrev.com/c/2548285 Original change's description: > Improve the setup logic for tryserver > > If the given change does not have a valid gerrit host name, stop > initializing the tryserver module. > Also polished the variable name and docstr added in crrev/c/2528670. > > Recipe-Nontrivial-Roll: infra > Bug:1146487 > Change-Id: I38193b25d37c724fd41d898eb020237fbf7cecdf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2544000 > Commit-Queue: Xinan Lin <linxinan@chromium.org> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> TBR=nodir@chromium.org,tandrii@google.com,recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com,linxinan@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: I3871866454adab816ab5549f8273fe16af2d9adb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2548409 Reviewed-by: Xinan Lin <linxinan@chromium.org> Commit-Queue: Xinan Lin <linxinan@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.