commit | 559d0cced70cdc0d4e68cd3bcefcbadd69b2e7f8 | [log] [tgz] |
---|---|---|
author | jam@chromium.org <jam@chromium.org> | Wed Aug 12 03:11:58 2015 |
committer | jam@chromium.org <jam@chromium.org> | Wed Aug 12 03:11:58 2015 |
tree | c8ff2c33bf3f52f7f88a01454c0e8f0c574ab0b7 | |
parent | 1114bdc45ce9c70f24ab34f1e0707148082e83c8 [diff] |
Revert of Fix the drift in repeating timers. (patchset #2 id:20001 of https://codereview.chromium.org/1261993006/ ) Reason for revert: this change caused a large amount of flakes, see https://code.google.com/p/chromium/issues/detail?id=517488 and also graphs on http://chrome-monitor.appspot.com/view_graph/tryserver.chromium.linux%20Builder%20linux_chromium_rel_ng%20Success%20Rate%20(Last%20100%20Builds) http://chrome-monitor.appspot.com/view_graph/tryserver.chromium.win%20Builder%20win_chromium_x64_rel_ng%20Success%20Rate%20(Last%20100%20Builds) http://chrome-monitor.appspot.com/view_graph/tryserver.chromium.win%20Builder%20win_chromium_rel_ng%20Success%20Rate%20(Last%20100%20Builds) this was hard to track down because browser_tests weren't printing renderer crashes. i fixed that in an unlanded cl and tried reenabling all the tests and they all had ASSERTION FAILED: now >= m_unalignedNextFireTime see the try runs on this patchset https://codereview.chromium.org/1284083002/#ps20001 i.e. one example: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/92022/steps/browser_tests%20%28with%20patch%29/logs/MSE_ClearKey_Prefixed_EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM_0 BUG=517488 Original issue's description: > Fix the drift in repeating timers. > > Currently repeating blink timers ignore the difference between when the > timer was due to fire and when it actually did. In addition the delay > reported to chromium was rounded up to the nearest millisecond, > introducing unnecessary extra delay. > > (Note seperatly DOMTimers have additional clamping). > > This fairly broken behaviour has been there for a long time, and I > really hope nothing has come to depend on it! > > Judging by > http://www.duckware.com/test/chrome/timeraccuracy.html this patch makes > things a lot better at least on linux. The actual delays are much > closer to the requested ones, and the run time modulo interval shows > the drift is gone. > > BUG=328700 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199903 TBR=jochen@chromium.org,skyostil@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=328700 Review URL: https://codereview.chromium.org/1290633002 git-svn-id: svn://svn.chromium.org/blink/trunk@200375 bbb929c8-8fbe-4397-9dbb-9b2b20218538