commit | 92e231dfbc6e41f5fb39bb65117561b714675620 | [log] [tgz] |
---|---|---|
author | Bence Béky <bnc@chromium.org> | Mon May 21 13:07:06 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon May 21 13:07:06 2018 |
tree | 6cdc34194b72074fc55682affab685b67069e457 | |
parent | 1f0bf6ad71ac18f58da26383644fc7a56fb8f6e0 [diff] |
Do not reset callback after moving. Unlike general move semantics, when a Callback (either OnceCallback or RepeatingCallback) is moved from, it is guaranteed to be left in a null state. (See, for example, [1].) This CL removes two Reset calls from a freshly moved-from Callback, and uses std::move instead of assignment then Reset for a third one. [1] https://cs.chromium.org/chromium/src/base/callback_helpers.h?l=24 Bug: 807724 Change-Id: I538408b26fc0b6af601b23a669cb5447d2f9b1fe Reviewed-on: https://chromium-review.googlesource.com/1064019 Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#560260}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .