commit | 56367281f9b94f9e151770e0a5da5f74623690e5 | [log] [tgz] |
---|---|---|
author | Hiroshige Hayashizaki <hiroshige@chromium.org> | Fri Oct 06 01:50:56 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 06 01:50:56 2017 |
tree | badc1cbc70ab03b9a36309b415ed368efcd95fca | |
parent | f67b0fc03dae8295c8b62999cc59651ffcb37ea0 [diff] |
Reduce usage of ModuleScript::IsErrored() and HasInstantiated() in tests IsErrored() and HasInstantiated() are to be removed because they are removed from the HTML spec in https://github.com/whatwg/html/pull/2991. This CL - Replaces IsErrored() calls in unit tests with checks for Instantiate() results or with HasEmptyRecord(), depending on whether instantiation errors or parse errors are tested, and - Removes EXPECT_FALSE(HasInstantiated()) from ModuleMapTest.cpp, because instantiation is already prohibited by NOTREACHED() in DummyModulator::InstantiateModule(). Bug: 763597 Change-Id: I272a03f3d5ce8ddf6ea645a3d0d1a1ae7543f2be Reviewed-on: https://chromium-review.googlesource.com/703483 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#506947}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .