commit | 52bbdd4e45ed7d03be5e407acc575914fc36a7c3 | [log] [tgz] |
---|---|---|
author | Marc Treib <treib@chromium.org> | Wed Jun 13 11:45:55 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 13 11:45:55 2018 |
tree | 5fa8e519050d3c7bc56c5cf81f5dc8e81dbe5bb3 | |
parent | 250cef84d714b3386a3910845842ea12c3a7abed [diff] |
ProfileSyncService: Add missing NotifyObservers() on unrecoverable error ...plus fix and reenable SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted. This test waits until it sees an unrecoverable error through the SyncServiceObserver. Since we weren't actually notifying in this case, it relied on a random different notification. Interestingly, adding the missing NotifyObservers() made the test hang consistently. My theory is that there was a possible deadlock between the sync thread and the main thread. It seems to be fixed by explicitly waiting for the main thread tasks to run before waiting on the sync thread. Bug: 850980 Change-Id: I2f636ddfa457b6d977f909e0d0a17a26aca5c166 Reviewed-on: https://chromium-review.googlesource.com/1097479 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#566801}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .