Google Git
Sign in
chromium / chromium / src / 0ed6d332ef1985d0c1cc1218cc273cf24e0cf83b
commit0ed6d332ef1985d0c1cc1218cc273cf24e0cf83b[log] [tgz]
authorPhilip Rogers <pdr@chromium.org>Thu Aug 02 21:25:11 2018
committerCommit Bot <commit-bot@chromium.org>Thu Aug 02 21:25:11 2018
treec3a04d700d5b1c66ab96bb03a7008dc7c47ed0c5
parente335101eedd3ab28d16dcb4b22e5ee0b60044b89 [diff]
Use property tree paint offset when snapping scrolling contents rect

This patch fixes a crash where we were using the wrong paint offset
when snapping the scrolling contents rect. Previously, the scrollable
area's location was used as the paint offset, but this is incorrect
and the property tree builder's context should be used instead.

This patch adds a unit test that mirrors a composited layer mapping
test of the same issue (ScrollLayerSizingSubpixelAccumulation). It
also adds a minimized layout test of the crash.

Bug: 868613

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2d045ae4d50ccb7a8eae6efbe2817e6e93d462ee
Reviewed-on: https://chromium-review.googlesource.com/1158798
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580327}
7 files changed
tree: c3a04d700d5b1c66ab96bb03a7008dc7c47ed0c5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .