commit | 58432fa5d027b99edce17353b46b35a417ac11f2 | [log] [tgz] |
---|---|---|
author | chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> | Mon Mar 22 08:32:35 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 22 08:32:35 2021 |
tree | f12cb03aeee8ff2412ea1f5235d54e747b127890 | |
parent | b84b6151ce672485ac9cae39ea0f2272cd72e6fd [diff] |
Roll luci-py from b54b7c23cff7 to c7c3017712c6 (1 revision) https://chromium.googlesource.com/infra/luci/luci-py.git/+log/b54b7c23cff7..c7c3017712c6 2021-03-22 momosasaki@google.com [client] Use subprocess42's wait() and not subprocess's on windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/luci-py-infra-autoroll Please CC tikuta+infra-roll@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: tikuta+infra-roll@chromium.org Change-Id: If9e23d50ac884d017ea7e38412342b43d8d3e56c Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2777793 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#39578}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.