| commit | 58ce4660835621899e0129250e690059d9ece8a9 | [log] [tgz] |
|---|---|---|
| author | krasin <krasin@google.com> | Thu Oct 01 21:09:01 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Oct 01 21:09:45 2015 |
| tree | c8b1cc61bbc9f5616f959016d6c16116aba3322c | |
| parent | a8c0d123705ae21071fc2f3d742537faaed1d455 [diff] |
Remove an assert that triggers a bad cast in blink::LifecycleNotifier. The bad cast happens in blink::LifecycleNotifier<blink::ExecutionContext, blink::ContextLifecycleObserver>::context(), when it's called from the destructor. See https://crbug.com/537398. The primary issue is that this method makes a base-to-derived cast at the time, when the derived instance is already destroyed. This bug was found by Control Flow Integrity check: https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity BUG=chromium:537398,chromium:464797 Review URL: https://codereview.chromium.org/1381823002 Cr-Commit-Position: refs/heads/master@{#351884}