commit | 545de80a86c0f1b94c0e354c0bf2c09b91fe69af | [log] [tgz] |
---|---|---|
author | Tien-Ren Chen <trchen@chromium.org> | Sat Sep 15 14:25:04 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Sep 15 14:25:04 2018 |
tree | 5c706e44e4df2d84704f6be3d231b6b69d8f0d1c | |
parent | 4a19ae010b1c420cb3650a29a72a5ef6ac93f627 [diff] |
[Blink/SPv175+] Change DCHECK(chunk clip escaped layer clip) to a DLOG This is a scaled-back version of a same-named previous CL. This version only converts the DCHECK into a DLOG, but keep the not-so-robust error recovery algorithm as-is. The PaintChunkToCcLayer algorithm was originally designed for SPv2 compositor, and it was expected the layerization algorithm should never assign a chunk to a excessively clipped layer, thus the DCHECK. Later this algorithm was adopted in SPv175 to be used with the SPv1 compositor. There is a known bug that in certain corner case we can fail to escape clip, and the bug is difficult to fix in the legacy architecture. The DCHECK is expected to be a "soft" one that we have a fail-safe path to recover in a sane way. BUG=881788,853357 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic534ea754ac392e839534e3bfbeb1fbccc64d120 Reviewed-on: https://chromium-review.googlesource.com/1227062 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591587}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .