commit | ff082c9239dab7f23f08dc40bb02909ec5f2e754 | [log] [tgz] |
---|---|---|
author | Luciano Pacheco <lucmult@chromium.org> | Thu Sep 20 07:16:58 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Sep 20 07:16:58 2018 |
tree | 819a27f07b6e60252d39c4d40dede01601d2cfd2 | |
parent | c1aad3ca98706b7288c0125fa80672d5d98e212a [diff] |
Fix Audio Player Polymer 1 configuration Audio Player was using Shadow DOM's polyfil, aka Shady DOM which is included in Polymer1. Chrome has had a fully working native Shadow DOM for quite a while. The remaining Polymer WebUI has already been using native Shadow DOM. This fix is to make Audio Player elements and tests compatible with Polymer2, tests still require further work to pass in Polymer2. Replace all occurrences of: "chrome://resources/polymer/v1_0/polymer/polymer.html" with: "chrome://resources/html/polymer.html" The new polymer.html configures Polymer 1.0 to run with ShadowRoot making these polymer elements be compatible with Polymer 2.0. Fix Audio Player tests: 1. Audio Player is compound of 3 main Polymer elements: * "audio-player": main component which use the other 2 below. * "control-panel": buttons to control, like play, pause, next, etc. * "track-list": List of all tracks to be played. 2. Files app and Audio player test utils, has the ability to query elements deep in the ShadowRoot, however it requires an Array of selectors instead of a simple string selector. For every element that has a ShadowRoot, we need to provide an element on the selector array. E.g.: ['audio-player', 'control-panel', '.some-class']: Gets "audio-player" then selects in its shadowRoot for "control-panel", then selects ".some-class" in "control-panel" shadowRoot. 3. Define "trackListQuery" and "controlPanelQuery" to make simpler to traverse these 2 Polymer sub-components. 4. Fix all selectors to make explicit the component traversal. Test: browser_tests --gtest_filter="AudioPlayer*:OpenAudioFiles*" Bug: 875525 Change-Id: I64e94452ff4cc8eb51137620013ad0cf00101f67 Reviewed-on: https://chromium-review.googlesource.com/1226478 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592709}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .