commit | 5b84e88a070e40a1a74576a6cf41109d29a8035a | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Tue Apr 03 13:14:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 03 13:14:36 2018 |
tree | d36305aae7f778b4cb0d8d06dbafc43f7d43561d | |
parent | 02ae8f5f6cb3389b7ffb841592f91035f13906a5 [diff] |
Remove custom bindings for CSSStyleDeclaration. Attempt to remove these custom bindings again after 2015's https://codereview.chromium.org/1119653002 and others. At the time the CLs were reverted because of performance regressions; I seem to be unable to trigger the perf trybots myself, so we will need to see if there is anything to fix after landing. There was nothing in the custom bindings that really required custom code, so the existing implementations of the named setter/getter/enumerator/query were moved almost as-is to CSSStyleDeclaration.cpp. The local supporting functions were almost untouched as well, except for the fact that they were moved into an anonymous namespace instead of being made static, and they all take AtomicString's in their arguments rather than String's. Removing these custom bindings helps get rid of named property queries (this was the only custom named query implementation in the tree), which we need to do in order to be able to instantiate indexed and named property handlers the same way and simplify our bindings code. Bug: 345519, 764633 Change-Id: I76171bb4c2ae23fc672748dc11b26094f16e573e Reviewed-on: https://chromium-review.googlesource.com/984232 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#547683}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .