Google Git
Sign in
chromium / chromium / src / 5b85d12f602d7ecb310d00d1bd673d1b3de81c65
commit5b85d12f602d7ecb310d00d1bd673d1b3de81c65[log] [tgz]
authorMoe Ahmadi <mahmadi@chromium.org>Thu Feb 07 21:28:54 2019
committerCommit Bot <commit-bot@chromium.org>Thu Feb 07 21:28:54 2019
treefbf9367d3c453771d65ccc3a8ce59697e174407c
parentef214ff9b662af5d947db5f675e744ae272f4b44 [diff]
[iOS][Translate] Fix translate infobar being created in "translating" state


Currently TranslateInforbarView and its subviews assume that the translate
infobar is always created in "before translate" state, i.e., the source
language tab would be selected and the target language tab would be
unselected.

The translate infobar, however, can be created in "translating" or "after
translate" states, i.e., the target language tab would be in loading or
selected states respectively. This CL removes the assumed default state and
instead propagates the default state to the TranslateInforbarView (and its
subviews) after creation.

TBR=droger@

Bug: 910994
Change-Id: Ifdb280a104e61cde81c703a490f7637986b76a72
Reviewed-on: https://chromium-review.googlesource.com/c/1448807
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630049}
4 files changed
tree: fbf9367d3c453771d65ccc3a8ce59697e174407c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .