| commit | 5d5091665700495b0d212cc504fd48530565eecf | [log] [tgz] |
|---|---|---|
| author | Dave Tu <dtu@chromium.org> | Thu Nov 08 01:12:51 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 08 19:59:55 2018 |
| tree | 8851d6c1ced7ba69fa38d8f77f7091482e77ff0c | |
| parent | f04a3a61ad90b65450499cfca9ae2f7b57054d03 [diff] |
[pinpoint] Let users with tryjob access launch Pinpoint jobs. Refactor api_request_handler to make it more flexible in the types of authentication it can do. Instead of _AllowAnonymous(), it has an overridable method _CheckUser() that checks the user's credentials. This way, we can override it to accept tryjob users. Replace PrivilegedPost() and UnprivilegedPost() with just Post(). There were no API handlers that treated privileged and unprivileged users differently. They only needed to be overridden to do access control. Previously there were three tiers of access control: * Override PrivilegedPost(). * This is now `def _CheckUser(self): self._CheckIsInternalUser()` * Override UnprivilegedPost() and PrivilegedPost(). * This is now `def _CheckUser(self): self._CheckIsLoggedIn()` * Override UnprivilegedPost(), PrivilegedPost(), and _AllowAnonymous(). * This is now the default behavior, allowing all users. Bug: chromium:895738 Change-Id: I35a2d9116bd98170ea17caeba9f8756b9304ceb1 Reviewed-on: https://chromium-review.googlesource.com/c/1319249 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Dave Tu <dtu@chromium.org>
Catapult is the home for several performance tools that span from gathering, displaying and analyzing performance data. This includes:
These tools were created by Chromium developers for performance analysis, testing, and monitoring of Chrome, but they can also be used for analyzing and monitoring websites, and eventually Android apps.
Please see our contributor's guide