commit | 5ed97224794084717685606d3d1eff72a008a828 | [log] [tgz] |
---|---|---|
author | Kevin Chowski <chowski@google.com> | Tue Mar 30 23:11:17 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 30 23:11:17 2021 |
tree | 5b02dc04cd7814580a3df9b71829c180be55ca35 | |
parent | 2a98b1ebabb6efd3aa64032b1f7dda810d689209 [diff] |
pinpoint fakelegacy: support /api/new endpoint. Adds very simple handling for creating new jobs: the user is recorded and a new random ID is generated. Future iterations can determine how to move these fake jobs through various other states. This CL also fixes a bad constant value that wasn't caught in prior versions; a unit test was updated to catch this. Change-Id: I976ef08553d72f3ab88742d3a3b7e9fedb11e3ce Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2792058 Commit-Queue: Kevin Chowski <chowski@google.com> Reviewed-by: Dean Berris <dberris@chromium.org> Cr-Commit-Position: refs/heads/master@{#39791}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.