commit | 5fdd4523d6af32ac6ac114f005a0669546494708 | [log] [tgz] |
---|---|---|
author | Koji Ishii <kojii@chromium.org> | Thu Oct 04 13:14:45 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Oct 04 13:14:45 2018 |
tree | af6c2ab545d4cec6a7f81165d9b856c054021611 | |
parent | 8f77ddb36a31e8d4ca211d27a89a57c4eef75139 [diff] |
[LayoutNG] Properly reset text metrics for new line in quirks mode When lines are wrapped, line-height quirks mode requires each line not to have a strut by default. LayoutNG does this by resetting |text_metrics|, but it forgot to reset |text_top| and |text_height|, two derived variables from |text_metrics|. This results in slightly different geometry for LayoutBR when the layout was paused and restarted from a break token (such as reusing unchanged lineboxes or an inline formatting context was fragmented) from when we layout from top to bottom. This patch properly resets these values so that the layout result is consistent in such cases. Also the changes match better to legacy. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I76cdb57daf68833639fc454862af1e296a89d4cd Reviewed-on: https://chromium-review.googlesource.com/c/1260743 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596642}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .