commit | 48a2f8302e2d232721a80641fa60fd6116672c94 | [log] [tgz] |
---|---|---|
author | Etienne Pierre-doray <etiennep@chromium.org> | Thu Nov 08 16:20:24 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 08 16:20:24 2018 |
tree | 98bc40c63236a4333eba52a2864c9db4168f4fb9 | |
parent | 8b5fc6f99f2df772e716ada06dbaf1d89b5395b7 [diff] |
[TaskScheduler]: Migrate off of ScopedAllowWait in /content/browser/browser_main_loop.cc base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=gab@chromium.org Bug: 766678 Change-Id: I51b024db95473edf6ee3efb82879c95be92b9191 Reviewed-on: https://chromium-review.googlesource.com/c/1325219 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#606490}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .