commit | 6068cf6b0b7348f09085a3256588f831653b4a52 | [log] [tgz] |
---|---|---|
author | Avi Drissman <avi@chromium.org> | Mon Oct 08 19:52:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 08 19:52:36 2018 |
tree | 40725f141911623fa3b8aaab33450811b9299338 | |
parent | dbffadb3cc285cd34d1e1d080aac15e161382d44 [diff] |
Revert "Fix bugs and improve perf in Touch Bar text suggestions." This reverts commit ad7c191591846d2138feeaa27d29db322a4cd0fe. Reason for revert: Causes crashes (893038, 893222). Original change's description: > Fix bugs and improve perf in Touch Bar text suggestions. > > - The old implementation recreated the Touch Bar on each keystroke (including > when hidden, I believe), which burns a significant amount of power while > typing. This new implementation updates the existing candidate list, if it > exists and isn't collapsed. > > - Removes a bunch of support code for a behavior that was disabled in r590669. > It moves the remaining code into RWHV itself instead of a dedicated > controller class, which I have mixed feelings about, but ultimately picked > because after the support code was removed, most of what was left was > plumbing between RWHV and TextSuggestionsTouchBarController. > > - [Bigish change] Moves text suggestions out of the window and into the RWHV, > so that hiding and showing as focus and web contents change is left to AppKit > and the responder chain. > > - Fixes small lifecyle-ish bugs around when use this kind of Touch Bar — now > it's tied to the RWHV's input type instead of using a special > WebContentsTextObserver. > > Bug: 717553, 881545 > Change-Id: I8e1eff6da7918f92cfdb47465196d5841a88a7e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1212004 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597371} TBR=avi@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717553, 881545, 893222, 893038 Change-Id: Ia35f365b4cd46b98a7ffe0181fbf656fc4f9e672 Reviewed-on: https://chromium-review.googlesource.com/c/1269077 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597652}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .