commit | 7578354354afd3b9c74c54585b3ed0a89c864850 | [log] [tgz] |
---|---|---|
author | Tsuyoshi Horo <horo@chromium.org> | Thu Nov 15 00:21:35 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 15 00:21:35 2018 |
tree | cf1e4e2abf23c594af3f9fa51e6add1483ed2136 | |
parent | 6e407a19775cd1b6dac5470031640420b60163f8 [diff] |
Support service worker handling of same origin favicon requests There was a bug that service workers can inject image into favicon cache of any origins (crbug.com/422250). This is becuase the icon URL is used as a key of the "favicons" table in ThumbnailDatabase. So currently MultiResolutionImageResourceFetcher sets the SkipServiceWorker flag of all favicon requests, to make it impossible to handle the fetch event of favicon requests in service workers. Ideally we should change the data scheme of ThumbnailDatabase not to reuse the favicon which was served from a service worker. But it is complicated to change the data scheme, and also there is a performance trade-off. So this cl change MultiResolutionImageResourceFetcher to set the SkipServiceWorker flag only for cross origin favicon requests. So the service worker can handle the same origin favicon requests. Bug: 448427 Change-Id: I3237ae9c4d0cc5d2374830e2c4865a8a852d37c6 Reviewed-on: https://chromium-review.googlesource.com/c/1333120 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#608189}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .