commit | 60c784b759508ed36a644304b541f0f10e61f1dd | [log] [tgz] |
---|---|---|
author | Ben Wells <benwells@chromium.org> | Tue Mar 27 04:34:58 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 27 04:34:58 2018 |
tree | abe93e6ef469cef783510eb99dfc439f4f176183 | |
parent | d7c0441db3c7a677ebc2c961b9345e6916644217 [diff] |
Revert "[Extensions] Remove manifest v1 support for accessible resources" This reverts commit 7a1b3bb0f7aa68093639da976f3b4ecedd4585d8. Reason for revert: Seems to have caused memory failures. Sample failure: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8760 with this in the stack views::WidgetDelegate::GetAccessibleWindowTitle Original change's description: > [Extensions] Remove manifest v1 support for accessible resources > > In manifest version 1, all extension resources were considered > accessible by the web (i.e., could be embedded within or > requested by a web page). In manifest v2, only resources > explicitly specified in the web_accessible_resources key are > accessible. Remove support for manifest v1, and always check > the web accessible resources. > > Update unit tests to migrate relevant tests and remove tests for > manifest v1-specific behavior. > > Bug: 816677, 816679 > Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146 > Reviewed-on: https://chromium-review.googlesource.com/953177 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545898} TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org Change-Id: Ifae57fc0f5cb2b738d48527af5e20c19eac5b0a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816677, 816679 Reviewed-on: https://chromium-review.googlesource.com/981336 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#546010}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .