| commit | 60fb40258dc3548735720b48a5a8cfad8c11ecbd | [log] [tgz] |
|---|---|---|
| author | boliu <boliu@chromium.org> | Thu Aug 18 02:23:09 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Aug 18 02:25:12 2016 |
| tree | 258a8e94c90723a1f290ecbe8af53de344cd939b | |
| parent | bf5100015e3ea13c299c43538e75269ccaeaab62 [diff] |
Revert of Migrate WebVR Cardboard implementation to GVR (patchset #20 id:380001 of https://codereview.chromium.org/2219203002/ ) Reason for revert: Android build failure on cronet: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20MIPS%20Builder/builds/4131 /b/build/slave/Android_Cronet_MIPS_Builder/build/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //third_party/gvr-android-sdk/BUILD.gn:27:1: Empty sources for copy command. copy("libgvr_shared_library") { ^------------------------------ You have to specify at least one file to copy in the "sources". See //device/vr/BUILD.gn:47:7: which caused the file to be included. "//third_party/gvr-android-sdk:libgvr", ^------------------------------------- GN gen failed: 1 step returned non-zero exit code: 1 Also suspect but have not confirmed causing these two build failures: https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/7419 https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/7722 Original issue's description: > Migrate WebVR Cardboard implementation to GVR > > BUG=389343 > > Committed: https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3 > Cr-Commit-Position: refs/heads/master@{#412710} TBR=dtrainor@chromium.org,girard@chromium.org,bshe@chromium.org,mthiesse@chromium.org,klausw@google.com,sievers@chromium.org,bajones@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=389343 Review-Url: https://codereview.chromium.org/2258513003 Cr-Commit-Position: refs/heads/master@{#412724}