commit | 6102d23e5ddd1b3dd8b197053f6099fd05578122 | [log] [tgz] |
---|---|---|
author | Charles Harrison <csharrison@chromium.org> | Sat Oct 07 01:30:44 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Oct 07 01:30:44 2017 |
tree | a3a54bdc830b5c733692f849ec7d7a73b3c73926 | |
parent | 99c4b53bc194d59d6156aa3ac58048a537f7a9ac [diff] |
BlockTabUnders: Log click through metrics This CL does a few things: 1. Stops using WebContentsDelegate to show the UI. Instead, we show the infobar manually. This makes things easier if we want to ever rename the infobar since it is used for more than just frame busts. 2. Allow the infobar to take a OnceClosure which is run when the user clicks the link. We use this for logging an additional enum for our action histogram. 3. It turned out the unit test suite was not being run on Android :(. This CL fixes it and also instruments the infobar code to expect infobars. Bug: 661629 Change-Id: I16e7d46863ce44aa9bb14667205598b7e91c20f7 Reviewed-on: https://chromium-review.googlesource.com/701700 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#507256}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .