commit | 61053d4768697c51bad15d7a9bdffa98c591bb7e | [log] [tgz] |
---|---|---|
author | wolenetz <wolenetz@chromium.org> | Mon Aug 24 23:35:58 2015 |
committer | Commit bot <commit-bot@chromium.org> | Mon Aug 24 23:36:42 2015 |
tree | 8d32680628889a029163a35ff7581a474ce08e2a | |
parent | a9cb6620ab1350a9e6abeddb8d4f20c6cabe7121 [diff] |
Revert of MSE: Verify MediaLog events created by existing MP4 unit tests (patchset #2 id:20001 of https://codereview.chromium.org/1300013002/ ) Reason for revert: Prerequisite CL (https://codereview.chromium.org/1300943002/) is breaking windows bots (http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41148), so reverting both this and it to unblock tree. Original issue's description: > MSE: Verify MediaLog events created by existing MP4 unit tests > > Similar to previous changes r342861 and > https://codereview.chromium.org/1300943002/, this change updates media > unit tests to provide a StrictMock<MockMediaLog> to verify MediaLog > events produced with existing MSE MP4 unit tests. While log message > maintenance burden is increased, helpers are used to reduce that burden > while gaining improved resilience against logging regression. > > This CL does not verify all possible MSE MP4 parser MEDIA_LOGs, just > those that are emitted by existing unit tests. > > TEST=no regression > > Committed: https://crrev.com/194a2651ece516dc91fa0da9aa1675afd307e36e > Cr-Commit-Position: refs/heads/master@{#345183} TBR=xhwang@chromium.org,chcunningham@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1306783003 Cr-Commit-Position: refs/heads/master@{#345205}