| commit | 6157340fb6556e63d62994d35c296b0815d8f88c | [log] [tgz] |
|---|---|---|
| author | Ben Pastene <bpastene@chromium.org> | Tue Oct 06 02:11:44 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 06 02:11:44 2020 |
| tree | fc9e7f0af2a17a9f144957bf59f5e21e91ebbf0b | |
| parent | c94be2884ed2eae302cf405848766d7c06d8b653 [diff] |
Reland swarming's optional_dimensions support in recipes. This is a partial revert of crrev.com/c/2341673. From the code that was originally deleted, it keeps: - Code that plumbs 'optional_dimensions' from pyl testing specs down to the chromium_swarming.api.SwarmingTask object class. It doesn't keep: - Code that adds the "--optional-dimensions" arg to `swarming.py trigger` invocations. We're transition things to the golang swarming CLI. So it's code that would end up being deleted anyway. It adds: - Code that adds additional task slices for tests that specify optional_dimensions when using the golang swarming CLI. Bug: 1132206 Change-Id: I7b2291be4799538f1dec05acb1c50429693acac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2441447 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.