commit | 766f3c614c1e21111fdff1af71e61f12720daf85 | [log] [tgz] |
---|---|---|
author | Koji Ishii <kojii@chromium.org> | Fri Dec 14 09:12:22 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 14 09:12:22 2018 |
tree | 7ee596b2dafc9991a8dafcbcd3faf994c9cf5ebd | |
parent | 69325de9331ff6da4165958a3278c594904b252e [diff] |
[LayoutNG] Fix 'text-align' applied to 'white-space: pre-wrap' This patch matches the behavior of 'text-align' applied to 'white-space: pre-wrap' and when the line wraps to the current engine; do not include for 'justify' but do include for other values. Spec is not clear on this regard. An issue filed at: https://github.com/w3c/csswg-drafts/issues/3440 It turned out that our tests cover the combination of the properties only when lines do not wrap. Because NGLineBreaker computes |has_only_trailing_spaces| as part of the line breaking, the last lines and single lines don't have such item. The difference caused the bug, but the lack of tests prevented finding the problem. This patch adds tests for this case. Also, computing trailing space is moved to NGLineInfo as we discovered it is needed in other cases too, with more cases covered and with unit tests. Bug: 913995 Change-Id: I49428f2dcf193e2b7a745431f82724308a17d90f Reviewed-on: https://chromium-review.googlesource.com/c/1374331 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#616617}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .