commit | f308c6727540f45873ee03e6f83384d6262a5583 | [log] [tgz] |
---|---|---|
author | Philip Rogers <pdr@chromium.org> | Tue Dec 18 21:55:06 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 18 21:55:06 2018 |
tree | a5962d3b37617efa5e5f0c21c6f6ec220dc4da1b | |
parent | f021d87eab39f718fb2db837a426c450b803b431 [diff] |
Move main thread scrolling reasons off cc::Layer This patch de-duplicates the main thread scrolling reasons on cc::Layer, cc::LayerImpl, and cc::ScrollNode, making cc::ScrollNode's main thread scrolling reasons the source of truth. The major changes in this patch are: 1) cc::LayerImpl now uses the main thread scrolling reasons on the associated cc::ScrollNode. With BlinkGenPropertyTrees (BGPT), blink will generate the correct main thread scrolling reasons in the scroll tree and set them on the cc::ScrollNodes. Pre-BlinkGenPropertyTrees, blink will set main thread scrolling reasons on cc::Layer which will then be used by cc's property tree builder to set the value on cc::ScrollNodes. 2) Blink's property tree builder now correctly calculates main thread scrolling reasons. A TODO has been added for composite-after-paint. 3) When BGPT is enabled, ScrollingCoordinator is no longer used to update main thread scrolling reasons. 4) The ScrollingCoordinator tests have been parameterized to work with BGPT. A TODO has been added to move these tests out of the scrolling coordinator test file. Bug: 915372 Change-Id: Ib3ca1cf19fbfed3d04629d9229a1ce684214f33b Reviewed-on: https://chromium-review.googlesource.com/c/1369187 Reviewed-by: vmpstr <vmpstr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#617642}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .