Google Git
Sign in
chromium / chromium / src / 61b63bd8bb1ef2ec4b71453dcb06b2878ef9025d
commit61b63bd8bb1ef2ec4b71453dcb06b2878ef9025d[log] [tgz]
authorMartin Kreichgauer <martinkr@google.com>Wed Aug 22 09:51:19 2018
committerCommit Bot <commit-bot@chromium.org>Wed Aug 22 09:51:19 2018
treec623df3c95c7366ab32e5430ac160d53d7b425e4
parentb292e4237a02018f8eafdddcd19709bc87c01364 [diff]
fido: disable back button in Touch ID UI sheet

TouchIdAuthenticator currently fails a DCHECK when GetAssertion or
MakeCredential get invoked multiple times. Using the Back button (and
then proceeding to Touch ID again) can trigger a second call to
DispatchRequest and therefore the DCHECK fail.

Clicking the back button on the Touch ID sheet would not dismiss the
native Touch ID dialog, which would then hover over the welcome screen
sheet. So simply disabling the button seems like the right thing to do.

Bug: 678128,847985
Change-Id: I90dbf5ab016a177811575a4db61ca12d15e43841
Reviewed-on: https://chromium-review.googlesource.com/1184236
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584983}
2 files changed
tree: c623df3c95c7366ab32e5430ac160d53d7b425e4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .