Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 620703002: Add isolate.clean_isolated_files and use in all related recipes. (Closed)

Created:
6 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Vadim Sh., jam, M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, dsinclair
Project:
tools
Visibility:
Public.

Description

Add isolate.clean_isolated_files and use in all related recipes. Before initiating a compile step on bots using isolates or swarming, clean the *.isolated files from the build directory. BUG=419031, 414808 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -17 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 2 chunks +7 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/gpu/api.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/api.py View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/resources/find_isolated_tests.py View 2 chunks +26 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 2 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/arm.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/force_swarming.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_cross_compile.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_deapply_patch.json View 2 chunks +22 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_blink.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_tryserver.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_blink.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_tryserver.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_blink.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_tryserver.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_blink.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_git.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_checkout.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver_blink.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_blink.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_tryserver.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_fyi.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/compile_fail_is_critical_on_main.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/compile_with_patch_fail.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/compile_without_patch_fail.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release_tot_angle.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/canary.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/canary.expected/linux_Debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/canary.expected/linux_Release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/canary.expected/mac_Debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/canary.expected/mac_Release.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/canary.expected/win_Debug.json View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/canary.expected/win_Release.json View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Russell (switch to Gerrit)
PTAL
6 years, 2 months ago (2014-09-30 22:00:13 UTC) #2
Vadim Sh.
LGTM
6 years, 2 months ago (2014-09-30 22:15:16 UTC) #3
Ken Russell (switch to Gerrit)
+dsinclair as FYI
6 years, 2 months ago (2014-09-30 22:15:47 UTC) #4
Ken Russell (switch to Gerrit)
OK. Here we go.
6 years, 2 months ago (2014-09-30 22:15:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620703002/1
6 years, 2 months ago (2014-09-30 22:16:50 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 22:18:44 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 292227

Powered by Google App Engine
This is Rietveld 408576698