Google Git
Sign in
chromium / chromium / src / acfba70b1553c50a47fc9a71ab759eeb79c1bc32
commitacfba70b1553c50a47fc9a71ab759eeb79c1bc32[log] [tgz]
authormark a. foltz <mfoltz@chromium.org>Fri Feb 08 04:47:50 2019
committerCommit Bot <commit-bot@chromium.org>Fri Feb 08 04:47:50 2019
treeb95abf007448db5b3e3aa8787cd6c454051aca71
parent86e0430c83a59bf9c23772a8cf1ca62a603c1625 [diff]
[Media Router] Simplify unit tests

This patch removes various 'trampoline' methods used to handle move-only
parameters or set expectations on callback parameters.  In most cases these
can be replaced by standard GMock idioms.

This patch does keep RouteResponseCallbackHandler, which is used to unpack and
set expectations on parts of RouteRequestResult.  A duplicate copy is removed in
this patch.

Bug: 851567
Change-Id: I4309327df4a437b4aa565837c4f7b0861dd3f208
Reviewed-on: https://chromium-review.googlesource.com/c/1459327
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630194}
9 files changed
tree: b95abf007448db5b3e3aa8787cd6c454051aca71
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .