commit | 98183fd5242cca41dab264f0f182e5c57ce54187 | [log] [tgz] |
---|---|---|
author | Joshua Bell <jsbell@chromium.org> | Fri Feb 08 09:59:23 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 08 09:59:23 2019 |
tree | d501f7ac45876dc59f3460c7571c920720e84710 | |
parent | 2965e8ee3b49a6d13d1ec27fe6a8f369b4c93803 [diff] |
Android Sign-In Manager: Disable bogus test preventing refactors The SigninManagerAndroidTest.DeleteGoogleServiceWorkerCaches test was found to not be testing anything useful. It uses a browsing data helper which is not hooked in anywhere to observe deletions, and the test's assertions have inverted expectations. It only passed due to a quirk in the test data (URLs without trailing slashes). Disabled to allow refactoring of dependent code, pending a rework. Bug: 929456 Change-Id: Ic7d7f8d0eae41f99bd8943f121c97b1a346fab19 Reviewed-on: https://chromium-review.googlesource.com/c/1459516 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#630260}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .