Google Git
Sign in
chromium / chromium / src / 5acd2b96f65e343c0b991c3f19977ec0a9d19675
commit5acd2b96f65e343c0b991c3f19977ec0a9d19675[log] [tgz]
authorMin Qin <qinmin@chromium.org>Wed Feb 13 02:17:59 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 13 02:17:59 2019
tree94730d6ce50e79edf642d102d5c6e03e82fbe249
parentf7257947b936a99eb7a3c74fa8c2252e364ab5ff [diff]
Allow url download without DownloadManagerImpl

This CL allows InProgressDownloadManager to download a URL without
DownloadManagerImpl. This allows download to happen with service manager
only mode. Once full browser is launched later, InProgressDownloadManager
will inform DownloadManagerImpl about these completed downloads, and
will assign download ID to them.
It also adds a variable into DownloadUrlParameters to specify whether
safe browsing is needed. If safe browsing is required, such download
request will fail. Otherwise, it will be carried out.

Bug: 927083
Change-Id: I118a66d79e8307dcedb4ee9d76ce7b5cbe50a5d1
Reviewed-on: https://chromium-review.googlesource.com/c/1460119
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631507}
14 files changed
tree: 94730d6ce50e79edf642d102d5c6e03e82fbe249
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .