commit | 5e1238eaccd197cf056f15e2ebf03f903c06b5c3 | [log] [tgz] |
---|---|---|
author | Kamila <hkamila@google.com> | Mon Feb 18 09:32:44 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 18 09:32:44 2019 |
tree | 86e5c3f31840d269012f80317504a11621e1f963 | |
parent | f882a7832615764f026f8920a55810db1d01f0e5 [diff] |
Avoid double entries in All sites search page This cl fixes the double entries bug in Settings -> Site settings -> All sites. -------------------------------------------------------------------- Detailed Explanation -------------------------------------------------------------------- Permissions scoped to REQUESTING_ORIGIN_AND_TOP_LEVEL_ORIGIN_SCOPE such as geolocation will be presented as (origin,embedder) where embedder can be same as origin, or null. Permissions scoped to WebsiteSettingsInfo::SINGLE_ORIGIN_ONLY_SCOPE will be presented as (origin, "*"). In permissionInfoIsForTopLevelOrigin(...) in SingleWebsitePreferences.java, permissions (origin, origin), (origin, null) and (origin, "*") are merged into one however in this area of the code they aren't. Which is why, in Android, when you visit the site (i.e. permissions.site) and click "site settings" in the right side of the omnibox, the website settings for permission.site list all the permissions set. However, if you go to "All sites", you will see two entries: permission.site permission.site embedded in * In this case, my cl makes "All sites" have only "permission.site" with all the permissions listed. -------------------------------------------------------------------- Screenshots -------------------------------------------------------------------- Before: https://imgur.com/a/O24YnrW After: https://imgur.com/a/jbquhoF -------------------------------------------------------------------- Bug: 806615 Change-Id: I5999221ddba4bf40833427ebc01a28419d551cbe Reviewed-on: https://chromium-review.googlesource.com/c/1343090 Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#633054}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .