commit | 2e04537b39f7847aad3a81930f7793aca66a35fc | [log] [tgz] |
---|---|---|
author | Tom Anderson <thomasanderson@chromium.org> | Thu Mar 14 18:08:31 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Mar 14 18:08:31 2019 |
tree | 41eb15f33a035d175831dee228f39f5d07775995 | |
parent | b4bd227d318ffe4e60cbe451068143bb89eacc71 [diff] |
More fixes necessary for Windows/libc++ Fixes more configurations when usinguse_custom_libcxx=true on Windows, in particular ASAN. Summary of changes: * base/test/test_suite.cc: IWYU: macros like _CRT_ASSERT are used without including <crtdbg.h> where they're defined. * chrome_elf/BUILD.gn: //build/config/sanitizers:default_sanitizer_flags are removed, causing the ASAN runtime to not be linked in. no_default_deps needs to be set in order to prevent pulling in libc++ which was built with asan, and therefore has dependencies on the ASAN runtime. Fixes undefined symbol errors. * third_party/yasm/BUILD.gn: Always uses the release CRT even on debug builds, so symbols like _CrtDbgReportW referenced by libc++ will be missing. Add no_default_deps to prevent undefined symbol errors when linking. BUG=801780 R=thakis Change-Id: I8f39531ec6c8df30bd6c689d257d5fc3bfb427a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521275 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#640841}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .