commit | 9294fcf1591dcc10e69ffddb70890d0e3c5b6594 | [log] [tgz] |
---|---|---|
author | Qingsi Wang <qingsi@chromium.org> | Mon Mar 18 20:21:52 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 18 20:21:52 2019 |
tree | a2f35a26bc0e5d49fe334927be7f69f5ba400ae3 | |
parent | f9c0b1eca6b69172d4530ecd8e842c73bc338823 [diff] |
Revert "Move the getUserMedia gating of mDNS protection to FilteringNetworkManager." This reverts commit 6130949eaaf724cec6c90b2b54515b9e3dfe81e1. Reason for revert: this change breaks the canary. TBR=sergeyu@chromium.org Original change's description: > Move the getUserMedia gating of mDNS protection to FilteringNetworkManager. > > Our previous implementation would destroy the connection to the mDNS > responder service host when the media capture permission is granted. > As a result, any mDNS candidate created before the grant would become > unresolvable. This issue is particularly evident when we have multiple > peer connections of the same origin, where a newly created peer > connection would temporarily toggle the permission to blocked before > restoring the granted status if the user did give the permission. This > could cause a peer connection created earlier and in the process of ICE > candidate gathering to perform unnecessary mDNS obfuscation. After this > change, the connection to the mDNS responder service host keeps alive, > but just becomes unavailable for registration of new names when we have > permissions granted. > > Bug: 930339, 937992 > Change-Id: I8ccdf0e6b578bc9e327337c6fbd102cdc542d15c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522687 > Commit-Queue: Qingsi Wang <qingsi@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641046} TBR=sergeyu@chromium.org,qingsi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 930339, 937992 Change-Id: I6f07087bceb320300e536a8c867fac8d8cd5a557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528921 Reviewed-by: Steve Anton <steveanton@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641749}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .