Google Git
Sign in
chromium / chromium / src / 648d903b6923f7d4dac5f2e780fed04b383538e1
commit648d903b6923f7d4dac5f2e780fed04b383538e1[log] [tgz]
authordanakj <danakj@chromium.org>Wed Feb 06 16:25:33 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 06 16:25:33 2019
tree36080045ddc738b779da9875f54b0db0cb4934c9
parent2a27db26ffb757606b7e5b8a004c8134861fc175 [diff]
Null out the WebWidgetClient in WebViewImpl::Close().

We null away the WebViewClient already, but once the WebWidget parts
are closed we want to accept the RenderWidget (ie WebWidgetClient) being
destroyed. So drop the pointer to the WebWidgetClient when the main
frame is detached from Close().

R=dcheng@chromium.org

Bug: 912193
Change-Id: Ib4e0916c5e4cefaf49cb529135d38010809c3ea0
Reviewed-on: https://chromium-review.googlesource.com/c/1454135
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629602}
1 file changed
tree: 36080045ddc738b779da9875f54b0db0cb4934c9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .