commit | e82a3d52416af97f6a3a03ad13cae7a238e6e948 | [log] [tgz] |
---|---|---|
author | Gauthier Ambard <gambard@chromium.org> | Fri Apr 12 14:38:53 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Apr 12 14:38:53 2019 |
tree | d26f55c4a5306c4597072f514ba14f55fe003326 | |
parent | eab14979107fffc3687676bc1b0c20ca73c56e03 [diff] |
[iOS] Reload NTP's all data with a delay This CL modifies the method in the NTP collection items handler to reload all the data by adding a delay before it is executed. The delay is necessary because UICollectionView's -reloadData method isn't working if another operation modifying the collection is taking place. When the user sign in, we got a callback to modify a section before reloading all the data, preventing the data from being completly reloaded. This creates a stale state where the items for the collection are updated but the cells aren't configured with those items. It can create an issue where we are presenting stale data to the user and also the delegate of the show/hide button is actually dealloc'ed so tapping the button does nothing. Bug: 945726 Change-Id: I993218c3af8422c2fa81a844efbd6b93b6877bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541223 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#650283}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .