commit 17af96ee7299fba1ca5dca3882b0fc6135557556
author Caitlin Fischer <caitlinfischer@google.com> Thu Apr 18 00:20:16 2019
committer Commit Bot <commit-bot@chromium.org> Thu Apr 18 00:20:16 2019
tree 059eeb846b4ede2e7b5f83379810093d684461ba
parent a7c573e369487c7978abab5aeb5ccd6cce7b9658

[Autofill] Implements GetLabelForProfile for address + contact forms.

This implementation has the following changes:

1. Passing the profiles to Create() rather than to GetLabels() to
determine whether phone numbers and email addresses should be shown on
address + contact forms. This allows us to keep the implementation of
GetLabels(), which would be the same for each non-address-plus-contact-
form LabelFormatter, in the base class.

2. Adding two functions to label_formatter_utils for helping to determine
whether phones and emails should be included in labels.

3. Having LabelFormatters store a reference to the profiles.

4. A bit of clean-up in label_formatter_utils.


Screenshots

Note that the text in the name fields changes for filtering.

Phone and email not shown for 1 suggestion for address plus contact:
https://screenshot.googleplex.com/w4aPQY6b3hb

Phone not shown when it's the same across all suggestions:
https://screenshot.googleplex.com/HEhZWtmSuyk

Email not shown when it's the same across all suggestions:
https://screenshot.googleplex.com/29xy0kvaVp0

Phone and email not shown when they're the same across all suggestions:
https://screenshot.googleplex.com/HuZAest6mfZ

Bug: 936168
Change-Id: I52cced242d54d0a3f7c881619fe1c27ae9081714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566373
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#651981}