commit | 3fd5a144928b75e1987d2dce4d059ea5d0af5b15 | [log] [tgz] |
---|---|---|
author | Robert Sesek <rsesek@chromium.org> | Mon May 13 21:41:15 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon May 13 21:41:15 2019 |
tree | 608277adb3832b663db98a0d34e06238b5b8a1fa | |
parent | 3f4d8135a97e22732ca48ebc23c073ad53bc218e [diff] |
Dissemble the app_mode_loader. Previously the app_mode_loader was packaged into a .app bundle. But because the Info.plist is modified as part of creating app shim shortcuts, only the executable was code signed. This left the Info.plist as an un-sealed resource. Under stricter code signing verification rules required for macOS notarization, an .app bundle cannot have an un-sealed Info.plist. To work around this, place the un-bundled executable in the Framework's Helpers directory and store the Info.plist file under Resources. When building app shims at runtime, the .app bundle structure will be created manually (rather than copying the whole pre-built bundle). Created app shims will still not be validly signed .app bundles, but the components carried within Chrome will pass validation. Test: Browser menu > More tools > Create shortcut creates an app shortcut that launches. Bug: 960886, 850199 Change-Id: Ia4521ee436bc3288084004e247fd9765fb93816a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609886 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659223}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .