commit | 65be571f6ac2f7942b4df9e50b24da517f829eec | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Mon Oct 15 20:26:10 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 15 20:26:10 2018 |
tree | 63b2ae635eeee5b420e992bd65e8b6919d3d8654 | |
parent | 1d6ccd829e124f99252cd0f73de12810e0678aa4 [diff] |
google_util: Explicitly use std::initializer_list with base::NoDestructor Follow-up to ac53c5c53 ("Remove CR_DEFINE_STATIC_LOCAL from /components"). Due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849, having base::NoDestructor<T<U>> and passing an initializer list of Us does not work if this is not done explicitly, as GCC incorrectly fails to determine which constructor overload to use: ../../components/google/core/common/google_util.cc: In function ‘bool google_util::{anonymous}::IsCanonicalHostGoogleHostname(base::StringPiece, google_util::SubdomainPermission)’: ../../components/google/core/common/google_util.cc:120:24: error: call of overloaded ‘NoDestructor(<brace-enclosed initializer list>)’ is ambiguous {GOOGLE_TLD_LIST}); See also: https://chromium-review.googlesource.com/c/chromium/src/+/1170905 Bug: 819294 Change-Id: Ie1490b6646d7998d636c485769caabf56c1cf44c Reviewed-on: https://chromium-review.googlesource.com/c/1275854 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#599733}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .