Google Git
Sign in
chromium / chromium / src / 12e78f45eeac375a24cee330622524ed37ac0a04
commit12e78f45eeac375a24cee330622524ed37ac0a04[log] [tgz]
authorAndrey Lushnikov <lushnikov@chromium.org>Wed Jun 05 19:05:48 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jun 05 19:05:48 2019
tree596c6d91726be6d54aa9ddc287bda9a1d81c28c6
parent36ad739166d68d09140114d2f86adfdcdae74d12 [diff]
DevTools: do not re-create DOMWrapperWorlds on same-process navigation

DevTools protocol exposes a few protocol methods to create isolated
worlds:
- `Page.addScriptToEvaluateOnNewDocument`
- `Page.createIsolatedWorld`

Whenever a same-process navigation happens, these worlds are not
desotryed - so instead of re-creating the worlds per se, we should
re-create just WindowProxies.

This was reported as https://github.com/GoogleChrome/puppeteer/issues/4449

R=caseq

Change-Id: I1056f64324a8c4f3c7a9f4a1f443b39a3b48cd29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634416
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666392}
4 files changed
tree: 596c6d91726be6d54aa9ddc287bda9a1d81c28c6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .