commit | 66ee8c74c29f7ce228531825ab123fae6ec81ea5 | [log] [tgz] |
---|---|---|
author | Quinten Yearsley <qyearsley@chromium.org> | Wed Jan 06 22:42:02 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 06 22:42:02 2021 |
tree | 179226d713eb36dc4864f2771bafde1b5c631731 | |
parent | 65b543f281afc63a2b20e7a9403e4b046fd3f98c [diff] |
tricium spellchecker: Expand the filetype to comment map list Tricium ignores unknown file types. Some extensions that appear in files in chromium and other repos are not found in the list yet, so this CL expands the list to contain a few more file types. Tested by running `make test` and verifying output, with added file Makefile.rules in test directory. Bug: 1162351 Change-Id: I27b83f8dcd90ffa10f80630cc8e8e306c05c84bd Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2612279 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#37351}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.