Google Git
Sign in
chromium / chromium / src / e2bd6845c71c6a9f497ecea1241f33c71303c2a1
commite2bd6845c71c6a9f497ecea1241f33c71303c2a1[log] [tgz]
authorShimi Zhang <ctzsm@chromium.org>Tue Jun 18 20:51:22 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jun 18 20:51:22 2019
tree9f2e043c40c8c0f304827424078e001e5546ac90
parent01a4ebe3f40420a995476f49b6e2c77a2b8b444e [diff]
Move Smart Selection blocking logic into SmartSelectionClient

Tests testSmartSelectionNormalFlow() and testSmartSelectionRest() are
flaky due to the bots are not always provisioned.

This CL fixed the flakiness by moving the blocking logic into
SmartSelectionClient. It simplifies the logic of
SelectionPopupController#showSelectionMenu(), makes the logic explicitly
related to Smart Selection.

In order to make it work, two tests in SelectionPopupControllerTest are
updated.

Bug: 967811
Change-Id: Ic758c46c3f51eab05d5619f295ccd8270567d8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661292
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670197}
4 files changed
tree: 9f2e043c40c8c0f304827424078e001e5546ac90
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .