Google Git
Sign in
chromium / chromium / src / 673a051b65e3ab4ae0c3fb23356ac00522e0ee3e
commit673a051b65e3ab4ae0c3fb23356ac00522e0ee3e[log] [tgz]
authorNigel Tao <nigeltao@chromium.org>Thu Dec 20 03:08:47 2018
committerCommit Bot <commit-bot@chromium.org>Thu Dec 20 03:08:47 2018
tree1ff5395bd6fd5f2967cd0a96d4804b07308a3dc1
parentd2b2593c5b86d1f3a3340cef43b397d9ade97d86 [diff]
Add an AppUpdate::StateIsNull method

This also loosens an AppUpdate's fields (state and delta) to allow
nullptr values.

Previously, when presenting the first AppUpdate for a given app_id, we
have duplicated the delta to also be the initial state, so that the
overall AppUpdate's FooChanged methods all return false. This makes it
awkward in client code that needs to do something (e.g. update a UI
icon) both for the initial update and whenever the icon actually
changes.

Follow-up commits will use the new StateIsNull method.

BUG=826982

Change-Id: I284977e7bbc692b0a7b725c658d96ba77e40cfbb
Reviewed-on: https://chromium-review.googlesource.com/c/1373250
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618091}
6 files changed
tree: 1ff5395bd6fd5f2967cd0a96d4804b07308a3dc1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .