commit | bb6f18149191675c58fb34bfae46a791a4fc54eb | [log] [tgz] |
---|---|---|
author | Peng Huang <penghuang@chromium.org> | Thu Jul 04 14:52:30 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jul 04 14:52:30 2019 |
tree | 97f23c950c33cf15f7924703567da8350fc28837 | |
parent | 33077799fa8a4401dd86aab2005b60f117a81efd [diff] |
Reland "VulkanSwapChain: fix rotation problems on Android." This reverts commit cb4c5dbd3c8ae83fe9639e8a56fed452fb083603. Reason for revert: Fix the problem in original CL Original change's description: > Revert "VulkanSwapChain: fix rotation problems on Android." > > This reverts commit 690d261e1f2d324545e3630e62fee45d408c3618. > > Reason for revert: DCHECKs are broken on Fuchsia. > > Original change's description: > > VulkanSwapChain: fix rotation problems on Android. > > > > There are two rotation related issues: > > 1. When Reshape() is called, vkGetPhysicalDeviceSurfaceCapabilitiesKHR() > > may return outdated capabilities (capabilities before rotation). > > Fixed it by always creating the swap chain with requested size, and > > then the swap chain size will match the surface size later. > > 2. Vulkan swapchain is already created with surface's current transform, > > but chrome only supports compositing frame with identify transform. > > > > This CL also delays calling VkAcquireNextImage(). > > > > Bug: 958914,957485 > > Change-Id: Ie51aa51500323aa6299ca9cb3f6c41eb9886ec81 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678676 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Auto-Submit: Peng Huang <penghuang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#674081} > > TBR=penghuang@chromium.org,rjkroege@chromium.org,piman@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 958914, 957485 > Change-Id: I2de256aca82a5d006269ed65347af5d337dab986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688367 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#674720} TBR=penghuang@chromium.org,rjkroege@chromium.org,sergeyu@chromium.org,piman@chromium.org Bug: 958914, 957485 Change-Id: Ifcc758346e61a576b1f25498ba2f133ca48182e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688553 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#674838}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .