commit | 67e12947007a4d2cc1975d0f366ddbd43b67ef8c | [log] [tgz] |
---|---|---|
author | Noel Gordon <noel@chromium.org> | Tue Oct 02 07:12:14 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Oct 02 07:12:14 2018 |
tree | bb4f3735d387154fff15d82cfffa2aa6cd627e79 | |
parent | 2f9fe77052ddd2d7583c5bdbd9491e8e9c82d06a [diff] |
Make openQuickViewScrollText robust The QuickView text <webview> provides no signal that it is loaded, but it does have a src attribute. That can used as a proxy for loaded, and help make a test that is robust (to load / script timing) on the bots. - make the text <webview> selector precise (.text-content class) - change the text scroll test to check the webview src attribute is non-empty before proceeding. - change to use scrollBy, and send incremental scrolls until the the scroll limit is reached [1]. [1] if the bot misses or drops a JS scrollBy request, no problem: just ask for it again. Bug: 891150 Change-Id: I0bb49c2b08b3535172819a3c1088fca5ba6fda94 Reviewed-on: https://chromium-review.googlesource.com/1256469 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595747}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .