commit | 794343abeedc8855a41cb2589380571f53998ef3 | [log] [tgz] |
---|---|---|
author | Vadym Doroshenko <dvadym@chromium.org> | Tue Aug 06 14:57:11 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Aug 06 14:57:11 2019 |
tree | f067fefa31ddce3625561ca84859c33b23b05a12 | |
parent | ad439ec45c9c6ee1271e4e06832bd09ed63aa2ca [diff] |
Refactoring: simplifying passwords filling code 1. Context: code for filling passwords in DOM is very convoluted. For username first flow, we need to fill only usernames, which is hard to do in the current setup. Let's refactor! This CL contains: 1.FillFormOnPasswordReceived is removed. It basically delegates filling to FillUserNameAndPassword, which is used now. 2.Checking origin of parent frames moved to a helper method. 3.2 arguments removed from FillUserNameAndPassword, they may be computed from other args anyway. The further CL will contain more simplification to FillUserNameAndPassword. Bug: 875768, 959776 Change-Id: Id1658401a8ec683a1a8db1117e816fe87f7dbaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738554 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#684338}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .