commit | 6899796671705603bab3ee6eefd21ac385ca9bc8 | [log] [tgz] |
---|---|---|
author | Dmitry Gozman <dgozman@chromium.org> | Sun Jan 20 02:33:15 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Sun Jan 20 02:33:15 2019 |
tree | d3128f96b7463e7f7f74aade187a2435f41019f1 | |
parent | add2f7a11d13cf857b95ccb575afcd5d66690532 [diff] |
DocumentLoader: make srcdoc navigations async (attempt #2) about:srcdoc is not actually an empty document, so there is no real need to load it synchronously. data-saver.html is split in two, because it relied on specific order between calling internals.setSaveDataEnabled and committing navigation for two separate srcdoc iframes. Includes the following fixes comparing to attempt #1: 1. When script removes iframe's srcdoc attribute after the navigation has been scheduled, but before we retrieve the srcdoc content from the attribute, we could try to load about:srcdoc from the network. Instead, we should just load an empty document. 2. Iframe with src="about:srcdoc" should just load blank instead of issuing a network request for about:srcdoc. 3. Simplify how we pass "is srcdoc" to the document itself, now using DocumentInit instead of calling a method on FrameLoader. This avoids a similar race between starting the main resource load and creating a document. Bug: 919839, 855189 Change-Id: Ie5a9cbcf66ab93b9deea09ee8e756d10e48c741b Reviewed-on: https://chromium-review.googlesource.com/c/1409809 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#624479}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .