commit | bd37ad542355bd70b20e5fa704b5094a76454042 | [log] [tgz] |
---|---|---|
author | Rune Lillesveen <futhark@chromium.org> | Mon Aug 26 15:58:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Aug 26 15:58:07 2019 |
tree | b0d9741114d812ca819886388b7c1a2087353fb8 | |
parent | 52236e1436092886f2e2af39a37f83394b676ebe [diff] |
Pass used color-scheme to SystemColor. System colors should resolve differently based on the used color-scheme value. See [1]. Ideally they should compute to the keyword to make inheritance work and have different used values for system colors based on color-scheme, but that needs to be resolved[2]. System colors are used for forms rendering. This CL is preparing for color-scheme specific forms rendering. Some places we use initial color-scheme in contexts where we have no ComputedStyle. These are typically offscreen canvas not connected to a particular element. It's possible we should use the root element computed value instead. The color interpolation needs to be fixed and I've added a TODO. Will follow up in another CL. No tests as there are no behavioral changes. [1] https://github.com/w3c/csswg-drafts/issues/3804 [2] https://github.com/w3c/csswg-drafts/issues/3847 Bug: 929098 Change-Id: Ie734e399c0dba82c59b221222c8e7ef365cae79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768139 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#690375}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .